Annotations to inject and extract data with auto-instrumentation

[SimoneGiusso]

Is your feature request related to a problem? Please describe.

• Tell Auto-instrumentation to add attribute to current active span
• Tell Auto-instrumentation to extract attribute from current span

Describe the solution you'd like

    // when calling this method the parameter1 and parameter2 are added to the current span
    @WithCurrentSpan
    public void myMethod(@SpanAttribute("parameter1") String parameter1,
        @SpanAttribute("parameter2") long parameter2) {
        <...>
    }

    // when calling this method the parameter1 is returned
    @WithCurrentSpan
    public String myMethod(@SpanAttribute("parameter1") String parameter1) {
        return paramter1;
    }

Describe alternatives you've considered
Use manual instrumentation.

[trask]

hi @SimoneGiusso!

    // when calling this method the parameter1 and parameter2 are added to the current span
    @WithCurrentSpan
    public void myMethod(@SpanAttribute("parameter1") String parameter1,
        @SpanAttribute("parameter2") long parameter2) {
        <...>
    }

check out #7787

    // when calling this method the parameter1 is returned
    @WithCurrentSpan
    public String myMethod(@SpanAttribute("parameter1") String parameter1) {
        return paramter1;
    }

Can you clarify this example? Wouldn't this capture the value of the method arg into the span attribute named parameter1 (similar to above example)?

[SimoneGiusso]

Hello indeed @SpanAttributesAnnotations seems already full filled the first thing I asked (my bad, I didn't see in the doc and I didn't checked the project).

For the second case, basically I would like to capture and use the data propagated within the trace. I think the only way to do it for now is with to use the OpenTelemetry API. In other words a way to let service 2 read the attribute service one sent with @SpanAttributesAnnotations.

[trask]

For the second case, basically I would like to capture and use the data propagated within the trace. I think the only way to do it for now is with to use the OpenTelemetry API.

can you clarify, maybe with some psuedo code, how you would do this today with the OpenTelemetry API?

[jkwatson]

moving this issue to the instrumentation repository...

[mateuszrzeszutek]

ping @SimoneGiusso

can you clarify, maybe with some psuedo code, how you would do this today with the OpenTelemetry API?

[SimoneGiusso]

can you clarify, maybe with some psuedo code, how you would do this today with the OpenTelemetry API?

I think the only way to achieve context propagation with the OpenTelemetry API is as explained in the doc and use the TextMapPropagator.

What I would like to have is an API similar to OpenTracing to propagate the context:

# client side
span.context.set_baggage_item('auth-token', '.....')

# server side (one or more levels down from the client)
token = span.context.get_baggage_item('auth-token')

[laurit]

@SimoneGiusso opentelemetry also has baggage api.

// on client
Baggage baggage = Baggage.builder().put("key", "value").build();
try (Scope ignore = baggage.makeCurrent()) {
  // call the server      
}

// on server
String value = Baggage.current().getEntryValue("key");

[mateuszrzeszutek]

@SimoneGiusso as discussed in open-telemetry/opentelemetry-java#5651, OTel baggage API is simply different from OpenTracing. It's not possible to 1:1 map OpenTracing to OTel, you have to restructure your code.

[SimoneGiusso]

@SimoneGiusso as discussed in open-telemetry/opentelemetry-java#5651, OTel baggage API is simply different from OpenTracing. It's not possible to 1:1 map OpenTracing to OTel, you have to restructure your code.

I'll try to restructure the code since where I set the baggage I don't make the call to the server.

[github-actions]

This has been automatically marked as stale because it has been marked as needing author feedback and has not had any activity for 7 days. It will be closed automatically if there is no response from the author within 7 additional days from this comment.