Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help wanted! Add code.* attributes to controller spans #7345

Open
1 of 25 tasks
trask opened this issue Nov 30, 2022 · 4 comments
Open
1 of 25 tasks

Help wanted! Add code.* attributes to controller spans #7345

trask opened this issue Nov 30, 2022 · 4 comments
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request

Comments

@trask
Copy link
Member

trask commented Nov 30, 2022

Capture code.namespace and code.function on controller and view spans.

Controller spans:

  • dropwizard/dropwizard-views-0.7
  • grails-3.0
  • jaxrs/jaxrs-1.0
  • jaxrs/jaxrs-2.0/jaxrs-2.0-annotations
  • jaxrs/jaxrs-3.0/jaxrs-3.0-annotations
  • jaxrs/jaxrs-common
  • jaxws/jaxws-2.0-axis2-1.6
  • jaxws/jaxws-common
  • jaxws/jaxws-cxf-3.0
  • jaxws/jaxws-jws-api-1.1
  • jaxws/jaxws-metro-2.2
  • jsf/jsf-mojarra-1.2
  • jsf/jsf-mojarra-3.0
  • jsf/jsf-myfaces-1.2
  • jsf/jsf-myfaces-3.0
  • play/play-mvc/play-mvc-2.4
  • ratpack/ratpack-1.4
  • spring/spring-webflux/spring-webflux-5.0
  • spring/spring-webmvc/spring-webmvc-common Add code attributes to spring webmvc controller spans #12839
  • spring/spring-ws-2.0
  • struts-2.3
  • tapestry-5.4
  • vaadin-14.2

View spans:

  • jsp-2.3
  • spring/spring-webmvc/spring-webmvc-common
@trask trask added the enhancement New feature or request label Nov 30, 2022
@trask trask mentioned this issue Nov 30, 2022
@arik-dig
Copy link
Contributor

arik-dig commented Dec 4, 2022

@trask I can take this task and start with JAX-RS Controllers and Spring-MVC Controllers.
Do I have your blessing?

@trask
Copy link
Member Author

trask commented Dec 4, 2022

👍

@arik-dig
Copy link
Contributor

@trask sorry, but seems that due to time constraints I won't be able to address it soon.

@trask trask added the contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome label Aug 24, 2023
@trask trask removed the contribfest label Nov 20, 2024
@trask trask changed the title Add "code" attributes to all controller spans Help wanted! Add code.* attributes to controller and view spans Dec 7, 2024
@trask trask pinned this issue Dec 7, 2024
@trask trask changed the title Help wanted! Add code.* attributes to controller and view spans Help wanted! Add code.* attributes to controller spans Dec 7, 2024
@SylvainJuge
Copy link
Contributor

Also please note that code.namespace and code.function are currently in the process of becoming part of the stable semantic conventions:

It should not prevent anyone contributing by capturing code.function, it just means that contributions here are even more likely to contribute to the stability of those attributes and that some follow-up PRs are expected in the affected areas once those attributes are stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants