Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed testing-common improvements and refactorings #2248

Closed
mateuszrzeszutek opened this issue Feb 10, 2021 · 1 comment
Closed

Proposed testing-common improvements and refactorings #2248

mateuszrzeszutek opened this issue Feb 10, 2021 · 1 comment
Labels
area:tests enhancement New feature or request

Comments

@mateuszrzeszutek
Copy link
Member

mateuszrzeszutek commented Feb 10, 2021

  • Reuse AssertJ-based assertions from the SDK testing module. This probably requires adding a bit of functionality to the SDK assertions first (there probably are some asserts that we have here and they're missing from the SDK testing module). Ideally in this repo we should only have thin Groovy wrappers over the SDK testing assertions.
  • Migrate as many test utilities from Groovy to Java (e.g. TraceUtils)
  • Refactor InMemoryExporter: it's not really an exporter, it only provides the waitForTraces() method. We should add a shortcut method to InstrumentationSpecification/InstrumentationExtension classes so that direct calls to waitForTraces() are eliminated. This is already done
  • Package structure:
    • io.opentelemetry.testing should be the general base package for all testing classes and utilities
    • All spock-related Groovy code should be in the package io.opentelemetry.testing.spock (base classes, assertion wrappers)
    • Javaagent bridging should be in the package io.opentelemetry.testing.javaagent
@trask
Copy link
Member

trask commented Dec 22, 2024

Closing, this is being done as part of #7195.

@trask trask closed this as completed Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:tests enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants