Fixes and options for gRPC instrumentation #13443
Conversation
luke-sterkowicz
force-pushed
the
grpc_count_for_messages
branch
from
377fe79 to
60dbca4
Compare
...agent/src/main/java/io/opentelemetry/javaagent/instrumentation/grpc/v1_6/GrpcSingletons.java
Outdated
Show resolved
Hide resolved
instrumentation/grpc-1.6/README.md
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| | System property | Type | Default | Description | | |||
| |-------------------------------------------------------------|---------|---------|----------------------------------------------------------------------------------------------------------------------------------------------------------------| | |||
| | `otel.instrumentation.grpc.message-events` | Boolean | `true` | Determines whether to add span event for each individual message received and sent. Set this to false in case of streaming large volumes of messages. | | |||
There was a problem hiding this comment.
I'd use otel.instrumentation.grpc.emit-message-events @trask should there also be experimental in the property name?
I'd change the description to use less opinionated language.
There was a problem hiding this comment.
Thanks. Fixed the name and description. I think using experimental could suggest that the events are experimental maybe (which is not true)?
...brary/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6/TracingClientInterceptor.java
Outdated
Show resolved
Hide resolved
| private static final AttributeKey<Long> GRPC_MESSAGES_RECEIVED = | ||
| AttributeKey.longKey("grpc.messages.received"); | ||
| private static final AttributeKey<Long> GRPC_MESSAGES_SENT = | ||
| AttributeKey.longKey("grpc.messages.sent"); |
There was a problem hiding this comment.
I think this naming would be a bit consistent with existing semantic conventions:
grpc.received.message_countgrpc.sent.message_count
can you open an issue in https://github.com/open-telemetry/semantic-conventions/issues to propose these two?
the semconv folks probably won't get to it for a bit since not actively working on rpc/grpc at the moment, but will be good to get it into the backlog for when they do
grpc.messages.receivedandgrpc.messages.sentfor providing message counts.otel.instrumentation.grpc.message-eventsfor disabling span events for idividual messages.Closes #13368