Skip to content

Commit f612bf8

Browse files
authored
Rework shutdown in lettuce 5.0 tests (#12927)
1 parent a84ade1 commit f612bf8

File tree

4 files changed

+16
-3
lines changed

4 files changed

+16
-3
lines changed

instrumentation/lettuce/lettuce-5.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/lettuce/v5_0/AbstractLettuceClientTest.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
import io.opentelemetry.instrumentation.testing.internal.AutoCleanupExtension;
1212
import io.opentelemetry.instrumentation.testing.junit.AgentInstrumentationExtension;
1313
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
14+
import java.util.concurrent.TimeUnit;
1415
import org.junit.jupiter.api.extension.RegisterExtension;
1516
import org.slf4j.Logger;
1617
import org.slf4j.LoggerFactory;
@@ -78,4 +79,16 @@ protected static StatefulRedisConnection<String, String> newContainerConnection(
7879

7980
return statefulConnection;
8081
}
82+
83+
static void shutdown(RedisClient redisClient) {
84+
// using shutdownAsync instead of redisClient.shutdown() because there is a bug in the redis
85+
// client that can cause the shutdown to hang
86+
try {
87+
redisClient.shutdownAsync(0, 15, TimeUnit.SECONDS).get(15, TimeUnit.SECONDS);
88+
} catch (InterruptedException exception) {
89+
Thread.currentThread().interrupt();
90+
} catch (Exception exception) {
91+
// ignore
92+
}
93+
}
8194
}

instrumentation/lettuce/lettuce-5.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/lettuce/v5_0/LettuceAsyncClientTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ static void setUp() throws UnknownHostException {
9393
@AfterAll
9494
static void cleanUp() {
9595
connection.close();
96-
redisClient.shutdown();
96+
shutdown(redisClient);
9797
redisServer.stop();
9898
}
9999

instrumentation/lettuce/lettuce-5.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/lettuce/v5_0/LettuceReactiveClientTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ static void setUp() throws UnknownHostException {
6363
@AfterAll
6464
static void cleanUp() {
6565
connection.close();
66-
redisClient.shutdown();
66+
shutdown(redisClient);
6767
redisServer.stop();
6868
}
6969

instrumentation/lettuce/lettuce-5.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/lettuce/v5_0/LettuceSyncClientTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ static void setUp() throws UnknownHostException {
7474
@AfterAll
7575
static void cleanUp() {
7676
connection.close();
77-
redisClient.shutdown();
77+
shutdown(redisClient);
7878
redisServer.stop();
7979
}
8080

0 commit comments

Comments
 (0)