You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
i see that in commit 4a90d19, the uprobe for the net/http server has been moved from
SEC("uprobe/HandlerFunc_ServeHTTP")
to
to SEC("uprobe/serverHandler_ServeHTTP")
I can see that the request parameters such as HTTPMethod, Path etc. was pushed into the spancontext at method entry before and after the change they have been moved to methodExit.
I understand that serverHandler_ServeHTTP gets invoked first, then the mux gets invoked and then uprobe/HandlerFunc_ServeHTTP gets invoked.
Is the change to move the execution to an even more outer level so that the span measurements can be more accurate or is there any other reason for it..
i see that in commit 4a90d19, the uprobe for the net/http server has been moved from
SEC("uprobe/HandlerFunc_ServeHTTP")
to
to SEC("uprobe/serverHandler_ServeHTTP")
I can see that the request parameters such as HTTPMethod, Path etc. was pushed into the spancontext at method entry before and after the change they have been moved to methodExit.
I understand that
serverHandler_ServeHTTP
gets invoked first, then the mux gets invoked and thenuprobe/HandlerFunc_ServeHTTP
gets invoked.Is the change to move the execution to an even more outer level so that the span measurements can be more accurate or is there any other reason for it..
Any clear reason for the change will be helpful.
@RonFed - Tagging as Ron made the change.
PR - https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/868/commits
Commit Id - 4a90d19
Thanks,
Ananth
The text was updated successfully, but these errors were encountered: