Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate New Client Metrics in otelhttp #6261

Open
9 tasks
Tracked by #5973
MrAlias opened this issue Oct 17, 2024 · 3 comments
Open
9 tasks
Tracked by #5973

Generate New Client Metrics in otelhttp #6261

MrAlias opened this issue Oct 17, 2024 · 3 comments
Labels

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Oct 17, 2024

The semconv.HTTPClient already produces the existing v1.20.0 client metrics (#6002). The following methods need to be updated to produce the new client HTTP metrics:

These updates should ensure that when OTEL_SEMCONV_STABILITY_OPT_IN="http/dup" is set the produced telemetry is compliant with these semantic conventions:

  • http.client.request.duration
    • Do not include the experimental attributes.
  • http.client.request.body.size

Do not include:

  • http.client.response.body.size
  • http.client.open_connections
  • http.client.connection.duration
  • http.client.active_requests

These metrics are optional, and since the existing instrumentation does not provide an equivalent, do not add additional metrics (at this time).

@MrAlias MrAlias changed the title Produce New Client Metrics Generate New Client Metrics in otelhttp Oct 17, 2024
@MrAlias MrAlias added this to the v1.32.0 milestone Oct 17, 2024
@MrAlias MrAlias added the help wanted Extra attention is needed label Oct 24, 2024
@ayoisaiah
Copy link

@MrAlias I'd like to take this one

@MrAlias MrAlias moved this from Todo to In Progress in Go: HTTP Semconv Migration Nov 4, 2024
@MrAlias MrAlias removed this from the v1.32.0 milestone Nov 7, 2024
@akstron
Copy link
Contributor

akstron commented Nov 12, 2024

Hi @ayoisaiah , are you currently working on it? If not, I would like to work on it.

@dmathieu
Copy link
Member

dmathieu commented Dec 4, 2024

@akstron due to the lack of PR being opened, and how long this issue has been assigned for, I think you should feel free to start working on this. Even without the issue being explicitly being assigned to you.

@MrAlias MrAlias moved this from In Progress to Todo in Go: HTTP Semconv Migration Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

4 participants