Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelgrpc: add WithSpanOptions behavior to stats_handler #5430

Open
josepedropereira opened this issue Apr 25, 2024 · 1 comment
Open

otelgrpc: add WithSpanOptions behavior to stats_handler #5430

josepedropereira opened this issue Apr 25, 2024 · 1 comment
Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request instrumentation: otelgrpc

Comments

@josepedropereira
Copy link

Problem Statement

otelgrpc stats_handler does not support the config SpanStartOptions, even tho this config is supported in the deprecated interceptors since #3768

Proposed Solution

Append SpanStartOptions to the stats_handler SpanStartOptions like it's done on the interceptors side to have the same functionality for both use cases.

@pellared
Copy link
Member

pellared commented Jul 31, 2024

From #5251 (review):

I am not sure if it is good to allow users to do that much.

The user can e.g. change the span kind using https://pkg.go.dev/go.opentelemetry.io/otel/trace#WithSpanKind or create attributes which are not aligned with the semantic conventions and they others may blame that the instrumentation library does not follow semantic conventions.

so folks can (for example), enable stack traces to record errors.

I am not sure if this is a good justification. This instrumentation library is not recording any errors.

I think we can discuss during the SIG meeting if we should make instrumentation libraries so configurable.

I am aware that there is a precedent that otelhttp and otelgrpc already have WithSpanOptions but maybe we should retrospect this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request instrumentation: otelgrpc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants