-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: Parse model from JSON #4412
Comments
PTAL @codeboten |
Changing the description to update the documentation instead of adding a new function. |
Was this ticket initially opened to address this? In order to provide a minimal API surface area, implementations MUST support the following: Parse(file) -> configAn API called The method returns a Configuration model that has been validated. This API MAY return an error or raise an exception, whichever is idiomatic to the implementation for the following reasons:
|
@carrbs Good finding 👍 Actually it should implement this: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/configuration/file-configuration.md#parse Take notice that the specification currently requires only supporting YAML. Making as blocker per spec. I updated the description. |
The specification mentions both JSON or YAML. Are you saying that since only one is required and YAML is preferred if nether/both are supported, then we should only implement YAML parsing? Just trying to clarify what blocked on specification means here |
|
@pellared ah fair... i missed this, as it goes against what's written further down :D |
Closing the issue for now. We can reopen it if needed. |
Implement https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/configuration/file-configuration.md#parse for JSON.
The text was updated successfully, but these errors were encountered: