Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test TestDefaultBatcher_NoSplit_WithTimeout on Windows #11869

Open
mx-psi opened this issue Dec 12, 2024 · 1 comment
Open

Flaky test TestDefaultBatcher_NoSplit_WithTimeout on Windows #11869

mx-psi opened this issue Dec 12, 2024 · 1 comment
Labels
area:exporter flaky test os:windows Windows specific issues

Comments

@mx-psi
Copy link
Member

mx-psi commented Dec 12, 2024

This test fails on Windows with

--- FAIL: TestDefaultBatcher_NoSplit_WithTimeout (0.25s)
    --- FAIL: TestDefaultBatcher_NoSplit_WithTimeout/infinate_workers (0.11s)
        default_batcher_test.go:203: 
            	Error Trace:	D:/a/opentelemetry-collector/opentelemetry-collector/exporter/internal/queue/default_batcher_test.go:203
            	Error:      	Condition never satisfied
            	Test:       	TestDefaultBatcher_NoSplit_WithTimeout/infinate_workers
FAIL
FAIL	go.opentelemetry.io/collector/exporter/internal/queue	2.733s
FAIL

Example failure: https://github.com/open-telemetry/opentelemetry-collector/actions/runs/12295355249/job/34312074125?pr=11863

Test introduced in #11580.
cc @sfc-gh-sili
@mx-psi mx-psi mentioned this issue Dec 12, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 12, 2024
@mx-psi
[chore] Skip TestDefaultBatcher_NoSplit_WithTimeout on Windows (#11870)
73ed007 
Relates to #11869
@sfc-gh-sili
Copy link
Contributor

Thanks for submitting the fix, Pablo!
Similar issue has been around before the new queue-batching mechanism was implemented (#10758), and it seems Windows only. I agree disabling these for Windows like what we do here would be the way to go.

This was referenced Dec 12, 2024
Open
Open
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this issue Dec 19, 2024
@mx-psi @HongChenTW
[chore] Skip TestDefaultBatcher_NoSplit_WithTimeout on Windows (open-…
066b615 
…telemetry#11870)

Relates to open-telemetry#11869
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:exporter flaky test os:windows Windows specific issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mx-psi @sfc-gh-sili