Remove deprecated scraperhelper.Scraper and helpers (#11803)

Signed-off-by: Bogdan Drutu <[email protected]>

Author: bogdandrutu

.chloggen/rm-deprecated-scraper.yaml

@@ -0,0 +1,25 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: breaking
+
+# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
+component: scraperhelper
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Remove deprecated scraperhelper.Scraper and helpers
+
+# One or more tracking issues or pull requests related to the change
+issues: [11803]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext:
+
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: [api]

receiver/scraperhelper/scraper.go

@@ -45,13 +45,6 @@ func AddScraper(t component.Type, scraper scraper.Metrics) ScraperControllerOpti
 	})
 }
 
-// Deprecated: [v0.115.0] use AddScraper.
-func AddScraperWithType(t component.Type, scrp Scraper) ScraperControllerOption {
-	// Ignore the error since it cannot happen because the Scrape func cannot be nil here.
-	newScrp, _ := scraper.NewMetrics(scrp.Scrape, scraper.WithStart(scrp.Start), scraper.WithShutdown(scrp.Shutdown))
-	return AddScraper(t, newScrp)
-}
-
 // WithTickerChannel allows you to override the scraper controller's ticker
 // channel to specify when scrape is called. This is only expected to be
 // used by tests.