Skip to content

Commit

Permalink
Explicitly set 0.0.0.0 on sample configurations (#408)
Browse files Browse the repository at this point in the history
* Explicitly set 0.0.0.0 on sample configurations

* Change wording of comment
  • Loading branch information
mx-psi authored Sep 27, 2023
1 parent 0f47e46 commit 0373892
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 0 deletions.
11 changes: 11 additions & 0 deletions configs/otelcol-contrib.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# To limit exposure to denial of service attacks, change the host in endpoints below from 0.0.0.0 to a specific network interface.
# See https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/security-best-practices.md#safeguards-against-denial-of-service-attacks

extensions:
health_check:
pprof:
Expand All @@ -9,9 +12,12 @@ receivers:
otlp:
protocols:
grpc:
endpoint: 0.0.0.0:4317
http:
endpoint: 0.0.0.0:4318

opencensus:
endpoint: 0.0.0.0:55678

# Collect own metrics
prometheus:
Expand All @@ -25,11 +31,16 @@ receivers:
jaeger:
protocols:
grpc:
endpoint: 0.0.0.0:14250
thrift_binary:
endpoint: 0.0.0.0:6832
thrift_compact:
endpoint: 0.0.0.0:6831
thrift_http:
endpoint: 0.0.0.0:14268

zipkin:
endpoint: 0.0.0.0:9411

processors:
batch:
Expand Down
11 changes: 11 additions & 0 deletions configs/otelcol.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# To limit exposure to denial of service attacks, change the host in endpoints below from 0.0.0.0 to a specific network interface.
# See https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/security-best-practices.md#safeguards-against-denial-of-service-attacks

extensions:
health_check:
pprof:
Expand All @@ -9,9 +12,12 @@ receivers:
otlp:
protocols:
grpc:
endpoint: 0.0.0.0:4317
http:
endpoint: 0.0.0.0:4318

opencensus:
endpoint: 0.0.0.0:55678

# Collect own metrics
prometheus:
Expand All @@ -25,11 +31,16 @@ receivers:
jaeger:
protocols:
grpc:
endpoint: 0.0.0.0:14250
thrift_binary:
endpoint: 0.0.0.0:6832
thrift_compact:
endpoint: 0.0.0.0:6831
thrift_http:
endpoint: 0.0.0.0:14268

zipkin:
endpoint: 0.0.0.0:9411

processors:
batch:
Expand Down

0 comments on commit 0373892

Please sign in to comment.