fix(azuremonitorreceiver): Azure Monitor receiver should not produce gaps in data points for PT1M time grains #37342
+141
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
an-mmx
force-pushed
the
fix/azure-monitor-receiver-time-grain
branch
5 times, most recently
from
f974529 to
ee3a095
Compare
…gaps in data points for PT1M time grains
an-mmx
force-pushed
the
fix/azure-monitor-receiver-time-grain
branch
from
ee3a095 to
9783d0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation of tracking for the last metrics fetch is highly sensitive to time, relying on
time.Now(). This sensitivity causes the loss of data points due to jitter in 1-minute intervals. I recommend a change request to implement a more robust comparison with the last minute of metrics fetch.Link to tracking issue
Fixes #37337
Testing
A new coverage introduced in unit test
Documentation
No documentation added