-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REQUEST: Repository maintenance on opentelemetry-collector-releases #2457
Comments
I support this |
Both https://github.com/open-telemetry/opentelemetry.io and https://github.com/open-telemetry/opentelemetry-js use a merge queue. I think having the same configuration as those would be reasonable here. |
Thanks @trask! I tried merging open-telemetry/opentelemetry-collector-releases/pull/751 but it seems like there is something related to the branch protection rules that needs to be set up in a different way: I don't think I am able to fix this on my own, maybe you can compare the branch protection rules that exist in the opentelemetry(.)io/opentelemetry-js repositories? |
My guess is that |
Looks like it worked now! I am closing this, but since we will be setting this up in other repositories, would you mind documenting what was done here to solve the branch protection error? |
Looks like it was the branch protection rule on I'm going to try narrowing these permissions down (see #2459), can you give me one more PR that I can send to the merge queue afterwards? |
Okay, you can try with open-telemetry/opentelemetry-collector-releases#736, just removed from the queue. I'll reopen until we get this right :) Another interesting bit (this may be on us): we have the merge queue now, but it seems like only the "Build" workflow is running 🤔 Despite having multiple |
Yeah, they mention this requirement here. |
ok, the configuration in #2459 looks like it's working
you may need to add
|
This was done in open-telemetry/opentelemetry-collector-releases/pull/755, I think what matters here is that the merge queue only waits/shows the jobs marked as required. I feel like that is an independent problem, we can make a separate request for adding further required checks in the future if needed. |
Affected Repository
https://github.com/open-telemetry/opentelemetry-collector-releases
Requested changes
Enable the Require merge queue setting on the branch protection rules for the main branch with "squash" merge method
Purpose
The Github documentation linked above puts it succinctly:
To be 100% transparent here our final goal is to enable the same configuration in https://github.com/open-telemetry/opentelemetry-collector-contrib, but we'd like to test the possible side effects of the new configuration in a smaller repository before doing so.
In the contrib repository, our goal is to improve contributor experience by accelerating merges. It's too much manual work to keep all PRs based on latest main, so the merge queue will help us here.
Expected Duration
Permanently
Repository Maintainers
The text was updated successfully, but these errors were encountered: