Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update query for cards to reschedule in sync hook #420

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

user1823
Copy link
Contributor

@user1823 user1823 commented Jun 8, 2024

Fix: Don't exclude cards done in filtered deck with rescheduling enabled

@user1823
Copy link
Contributor Author

user1823 commented Jun 8, 2024

A scope for improvement:

If auto_disperse_after_reschedule is enabled, don't exclude Manual entries (i.e., remove the condition ease > 0).

This will allow the add-on to disperse siblings after the user optimizes the parameters and uses "Reschedule cards on change" on another device.

@L-M-Sherlock
Copy link
Member

Have you tested it several times?

@user1823
Copy link
Contributor Author

user1823 commented Jun 8, 2024

I have tested it a few times. If you want, you can wait for 1-2 days so that I get to test it more.

To clarify, I am talking about the changes already made in this PR. I don't know how to implement the change I proposed in my comment (#420 (comment)).

@L-M-Sherlock
Copy link
Member

I have tested it a few times. If you want, you can wait for 1-2 days so that I get to test it more.

It would be better if you can test it more.

I don't know how to implement the change

See my last commit 150b73f. Could you help me test it?

@user1823
Copy link
Contributor Author

user1823 commented Jun 8, 2024

See my last commit. Could you help me test it?

Seems to be working well.

@user1823
Copy link
Contributor Author

I have tested it multiple times and it seems to be working well.

Copy link
Member

@L-M-Sherlock L-M-Sherlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@L-M-Sherlock L-M-Sherlock merged commit 18e9ec3 into open-spaced-repetition:main Jun 11, 2024
1 check passed
@user1823 user1823 deleted the patch-1 branch June 11, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants