Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/new fuzz range for overdue card #398

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

L-M-Sherlock
Copy link
Member

@L-M-Sherlock L-M-Sherlock commented Apr 26, 2024

may fix #383

@L-M-Sherlock L-M-Sherlock force-pushed the Feat/new-fuzz-range-for-overdue-card branch from 26b5115 to 35d7c1f Compare April 26, 2024 15:28
@L-M-Sherlock
Copy link
Member Author

@user1823, what about the latest commit?

@user1823
Copy link
Contributor

When is self.allow_to_past True and False respectively?

@L-M-Sherlock
Copy link
Member Author

When the user applies easy days for specific days, it's False.

if config.load_balance:
fsrs.set_load_balance()
fsrs.easy_days = config.easy_days
fsrs.easy_days_review_ratio = config.easy_days_review_ratio
fsrs.p_obey_easy_days = p_obey_easy_days(
len(fsrs.easy_days), fsrs.easy_days_review_ratio
)
fsrs.easy_specific_due_dates = easy_specific_due_dates
fsrs.p_obey_specific_due_dates = obey_specific_due_dates(
len(fsrs.easy_specific_due_dates), fsrs.easy_days_review_ratio
)
if len(easy_specific_due_dates) > 0:
fsrs.allow_to_past = False

@user1823
Copy link
Contributor

Ok, it is acceptable.

However, a better solution would be to also create new fuzz ranges when pressing Apply easy days now and when Auto apply easy days on closing collection runs.

If the above is difficult to implement, I am OK with merging this PR as it is.

@L-M-Sherlock
Copy link
Member Author

Patch: fsrs4anki-helper.ankiaddon.zip

Copy link
Contributor

@user1823 user1823 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@L-M-Sherlock L-M-Sherlock merged commit 86199dd into main Apr 26, 2024
2 checks passed
@L-M-Sherlock L-M-Sherlock deleted the Feat/new-fuzz-range-for-overdue-card branch April 26, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Huge backlog of cards created when I try to apply easy days
2 participants