Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/disperse siblings after reschedule #393

Merged
merged 5 commits into from
Apr 22, 2024
Merged

Feat/disperse siblings after reschedule #393

merged 5 commits into from
Apr 22, 2024

Conversation

L-M-Sherlock
Copy link
Member

@L-M-Sherlock L-M-Sherlock commented Apr 21, 2024 •
edited

@L-M-Sherlock L-M-Sherlock added the enhancement New feature or request label Apr 21, 2024
@L-M-Sherlock L-M-Sherlock linked an issue Apr 21, 2024 that may be closed by this pull request
Use disperse siblings by default after reschedule #174
Closed
@user1823
Copy link
Contributor

user1823 commented Apr 21, 2024 •
edited

Doesn't work

Test deck: Test.apkg.zip (Rename to remove .zip)

  • Before rescheduling, 19 cards are due.
  • After rescheduling (with disperse), 126 cards are due.
  • After clicking disperse all siblings (after rescheduling), 54 cards are due.

Also, after clicking Reschedule all cards, the tooltip says "5339 cards rescheduled, 0 cards in 0 notes dispersed" even though all cards in this deck have siblings.

@L-M-Sherlock
Copy link
Member Author

New patch: fsrs4anki-helper.ankiaddon.zip

user1823
user1823 reviewed Apr 21, 2024
View reviewed changes
Copy link
Contributor

@user1823 user1823 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't have the time to test it till tomorrow evening. Till then, I have the following two suggestions.

__init__.py Outdated Show resolved Hide resolved
config.json Outdated Show resolved Hide resolved
@user1823
Copy link
Contributor

LGTM

@L-M-Sherlock L-M-Sherlock merged commit ffd0273 into main Apr 22, 2024
2 checks passed
@L-M-Sherlock L-M-Sherlock deleted the Feat/disperse-siblings-after-reschedule branch April 22, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@user1823 user1823 user1823 left review comments

@Expertium Expertium Awaiting requested review from Expertium

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use disperse siblings by default after reschedule
2 participants
@L-M-Sherlock @user1823