Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Store dates for Easy Days #378

Closed
Expertium opened this issue Mar 17, 2024 · 7 comments · Fixed by #416
Closed

[Feature Request] Store dates for Easy Days #378

Expertium opened this issue Mar 17, 2024 · 7 comments · Fixed by #416
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Expertium
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Right now, setting a specific date for Easy Days has very little use because the add-on doesn't remember the date.

Describe the solution you'd like
Store the dates in add-on config.

@Expertium Expertium added the enhancement New feature or request label Mar 17, 2024
@L-M-Sherlock
Copy link
Member

The current implementation is intended. If we store the specific date, it will be stored in the config.json permanently. And the add-on needs to read them from config when rescheduling. It would make the process more complex.

In addition, specific dates are not periodical like Easy Days of week. It's unnecessary to store them because they will be useless when the dates pass.

@Expertium
Copy link
Contributor Author

Expertium commented Mar 17, 2024

But then the user has to re-apply Easy Days to that date. And if the best result is achieved by applying Easy Days one day before the specific date, it makes this feature almost entirely useless.

@L-M-Sherlock
Copy link
Member

it makes this feature almost entirely useless

I don't think so. The specific dates are rare.

@Expertium
Copy link
Contributor Author

@user1823 what's your opinion?

@user1823
Copy link
Contributor

I think that the feature of Easy Days on specific dates is useless until #372 is solved. So, I don't recommend making any changes until we find a solution for #372.

if the best result is achieved by applying Easy Days one day before the specific date, it makes this feature almost entirely useless.

Not entirely useless, but less effective because the reviews can be shifted to the dates ahead but not behind the Easy Day.

@peter-moran
Copy link

+1 for interest in this. I agree that Easy Days on specific dates does not make sense if it is only a one-time operation (unlike easy days on a specific weekday) since reviews may end up on that day after you set it as an easy day.

I'd like to use the feature to have some easy days while on vacation, but without it getting memorized if I set the easy day up early it doesn't matter b/c reviews later get scheduled to that day.

@L-M-Sherlock L-M-Sherlock added the help wanted Extra attention is needed label Apr 15, 2024
@L-M-Sherlock L-M-Sherlock pinned this issue Apr 30, 2024
@L-M-Sherlock L-M-Sherlock linked a pull request May 18, 2024 that will close this issue
@L-M-Sherlock
Copy link
Member

Have a try: fsrs4anki-helper.ankiaddon.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants