Skip to content

Commit aac1647

Browse files
committed
btl: fix ompi_info for btl_flags
The flag enumerator used for btl_flags was missing an entry for the MCA_BTL_FLAGS_RDMA_REMOTE_COMPLETION flags. If this flag was set on a btl then it would cause ompi_info to fail when attempting to get the value for btl_flags leading to it just being omited from the output (another bug since it should fail and print an error). Signed-off-by: Nathan Hjelm <[email protected]>
1 parent ba35ec8 commit aac1647

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

opal/mca/btl/base/btl_base_frame.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ mca_base_var_enum_value_flag_t mca_btl_base_flag_enum_flags[]
5858
{MCA_BTL_FLAGS_PUT_AM, "put-am", MCA_BTL_FLAGS_PUT},
5959
{MCA_BTL_FLAGS_GET_AM, "get_am", MCA_BTL_FLAGS_GET},
6060
{MCA_BTL_FLAGS_ATOMIC_AM_FOP, "atomic-am", MCA_BTL_FLAGS_ATOMIC_FOPS},
61+
{MCA_BTL_FLAGS_RDMA_REMOTE_COMPLETION, "rdma-remote-completion", 0},
6162
{0, NULL, 0}};
6263

6364
mca_base_var_enum_value_flag_t mca_btl_base_atomic_enum_flags[]

opal/mca/btl/btl.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -273,6 +273,9 @@ typedef uint8_t mca_btl_base_tag_t;
273273
*/
274274
#define MCA_BTL_FLAGS_RDMA_REMOTE_COMPLETION 0x800000
275275

276+
/* End of btl flags. if additional flags are added please update
277+
* mca_btl_base_flag_enum_flags in btl_base_frame.c */
278+
276279
/* Default exclusivity levels */
277280
#define MCA_BTL_EXCLUSIVITY_HIGH (64 * 1024) /* internal loopback */
278281
#define MCA_BTL_EXCLUSIVITY_DEFAULT 1024 /* GM/IB/etc. */

0 commit comments

Comments
 (0)