Skip to content

Commit 53dc796

Browse files
committed
disable async NBC-based cleanup for now
Signed-off-by: Howard Pritchard <[email protected]>
1 parent b8535be commit 53dc796

File tree

1 file changed

+28
-20
lines changed

1 file changed

+28
-20
lines changed

ompi/mpi/bindings/ompi_bindings/c_type.py

Lines changed: 28 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -674,18 +674,22 @@ class TypeDatatypeArrayAsyncStandard(TypeDatatypeArrayStandard):
674674
def need_async_cleanup(self):
675675
return True
676676

677+
#
678+
# TODO: this code is deactivated till we fix the NBC cleanup callback methods
679+
#
677680
@property
678681
def final_code(self):
679-
request_tmp_name = util.abi_tmp_name('request')
680-
code = []
681-
code.append('if((MPI_SUCCESS == ret_value) && (MPI_REQUEST_NULL != request_tmp)){')
682-
code.append(f'ompi_coll_base_nbc_request_t* nb_request = (ompi_coll_base_nbc_request_t*){request_tmp_name};')
683-
code.append(f'nb_request->data.release_arrays[idx++] = (void *){self.tmpname};')
684-
code.append('nb_request->data.release_arrays[idx] = NULL;')
685-
code.append('} else {')
686-
code.append(f'if (NULL != {self.tmpname}) free({self.tmpname});')
687-
code.append('}')
688-
return code
682+
return []
683+
# request_tmp_name = util.abi_tmp_name('request')
684+
# code = []
685+
# code.append('if((MPI_SUCCESS == ret_value) && (MPI_REQUEST_NULL != request_tmp)){')
686+
# code.append(f'ompi_coll_base_nbc_request_t* nb_request = (ompi_coll_base_nbc_request_t*){request_tmp_name};')
687+
# code.append(f'nb_request->data.release_arrays[idx++] = (void *){self.tmpname};')
688+
# code.append('nb_request->data.release_arrays[idx] = NULL;')
689+
# code.append('} else {')
690+
# code.append(f'if (NULL != {self.tmpname}) free({self.tmpname});')
691+
# code.append('}')
692+
# return code
689693

690694
@Type.add_type('DATATYPE_ARRAY_OUT', abi_type=['standard'])
691695
class TypeDatatypeArrayOutStandard(StandardABIType):
@@ -750,18 +754,22 @@ class NeighborDatatypeArrayAsyncStandard(NeighborDatatypeArrayStandard):
750754
def need_async_cleanup(self):
751755
return True
752756

757+
#
758+
# TODO: this code is deactivated till we fix the NBC cleanup callback methods
759+
#
753760
@property
754761
def final_code(self):
755-
request_tmp_name = util.abi_tmp_name('request')
756-
code = []
757-
code.append('if((MPI_SUCCESS == ret_value) && (MPI_REQUEST_NULL != request_tmp)){')
758-
code.append(f'ompi_coll_base_nbc_request_t* nb_request = (ompi_coll_base_nbc_request_t*){request_tmp_name};')
759-
code.append(f'nb_request->data.release_arrays[idx++] = (void *){self.tmpname};')
760-
code.append('nb_request->data.release_arrays[idx] = NULL;')
761-
code.append('} else {')
762-
code.append(f'if (NULL != {self.tmpname}) free({self.tmpname});')
763-
code.append('}')
764-
return code
762+
return []
763+
# request_tmp_name = util.abi_tmp_name('request')
764+
# code = []
765+
# code.append('if((MPI_SUCCESS == ret_value) && (MPI_REQUEST_NULL != request_tmp)){')
766+
# code.append(f'ompi_coll_base_nbc_request_t* nb_request = (ompi_coll_base_nbc_request_t*){request_tmp_name};')
767+
# code.append(f'nb_request->data.release_arrays[idx++] = (void *){self.tmpname};')
768+
# code.append('nb_request->data.release_arrays[idx] = NULL;')
769+
# code.append('} else {')
770+
# code.append(f'if (NULL != {self.tmpname}) free({self.tmpname});')
771+
# code.append('}')
772+
# return code
765773

766774
@Type.add_type('OP', abi_type=['ompi'])
767775
class TypeOp(Type):

0 commit comments

Comments
 (0)