Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] grpc_sync.go is hard to test #1562

Open
cupofcat opened this issue Feb 14, 2025 · 0 comments
Open

[CHORE] grpc_sync.go is hard to test #1562

cupofcat opened this issue Feb 14, 2025 · 0 comments

Comments

@cupofcat
Copy link

https://github.com/open-feature/flagd/blob/main/core/pkg/sync/grpc/grpc_sync.go makes calls to grpc (e.g. NewClient) and different parameters are set based on grpc.Sync configuration. Ideally, we would test whether than configuration affects the calls to grpc, for example by using mocks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cupofcat