Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add targeting key #231

Merged
merged 8 commits into from
Feb 12, 2024
Merged

Conversation

roelofb
Copy link
Contributor

@roelofb roelofb commented Feb 7, 2024

Fixes #230

@roelofb roelofb requested a review from a team as a code owner February 7, 2024 07:55
@roelofb roelofb changed the title Fixes #230 Fix: Add targeting key Feb 7, 2024
@roelofb roelofb changed the title Fix: Add targeting key fix: Add targeting key Feb 7, 2024
Signed-off-by: Roelof Blom <[email protected]>
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1082094) 94.16% compared to head (cea58b6) 94.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
+ Coverage   94.16%   94.28%   +0.11%     
==========================================
  Files          25       25              
  Lines        1046     1067      +21     
  Branches      112      115       +3     
==========================================
+ Hits          985     1006      +21     
  Misses         37       37              
  Partials       24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Roelof Blom <[email protected]>
src/OpenFeature/Model/EvaluationContextBuilder.cs Outdated Show resolved Hide resolved
src/OpenFeature/Model/EvaluationContextBuilder.cs Outdated Show resolved Hide resolved
src/OpenFeature/Model/EvaluationContextBuilder.cs Outdated Show resolved Hide resolved
roelofb and others added 3 commits February 7, 2024 23:38
Co-authored-by: Austin Drenski <[email protected]>
Signed-off-by: Roelof Blom <[email protected]>
Co-authored-by: Austin Drenski <[email protected]>
Signed-off-by: Roelof Blom <[email protected]>
Co-authored-by: Austin Drenski <[email protected]>
Signed-off-by: Roelof Blom <[email protected]>
@roelofb roelofb requested a review from austindrenski February 7, 2024 22:45
src/OpenFeature/Model/EvaluationContextBuilder.cs Outdated Show resolved Hide resolved
src/OpenFeature/Model/EvaluationContextBuilder.cs Outdated Show resolved Hide resolved
src/OpenFeature/Model/EvaluationContextBuilder.cs Outdated Show resolved Hide resolved
Signed-off-by: Austin Drenski <[email protected]>
@roelofb
Copy link
Contributor Author

roelofb commented Feb 8, 2024

Not sure how to fix this test failure, the test harness looks incredibly involved TBH

@toddbaert
Copy link
Member

Not sure how to fix this test failure, the test harness looks incredibly involved TBH

Ya. We have an issue to fix this. I think this is similar to #223 (comment). I will try to fix this today.

@toddbaert toddbaert self-requested a review February 10, 2024 21:03
@toddbaert
Copy link
Member

I'll merge this Monday unless anyone objects!

Thanks a lot @roelofb !

@toddbaert toddbaert requested a review from askpt February 10, 2024 21:05
@toddbaert toddbaert merged commit d792b32 into open-feature:main Feb 12, 2024
13 checks passed
beeme1mr pushed a commit that referenced this pull request Mar 12, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.5.0](v1.4.1...v1.5.0)
(2024-03-12)


### 🐛 Bug Fixes

* Add targeting key
([#231](#231))
([d792b32](d792b32))
* Fix NU1009 reference assembly warning
([#222](#222))
([7eebcdd](7eebcdd))
* invalid editorconfig
([#244](#244))
([3c00757](3c00757))


### ✨ New Features

* Flag metadata
([#223](#223))
([fd0a541](fd0a541))
* implement in-memory provider
([#232](#232))
([1082094](1082094))


### 🧹 Chore

* bump spec version badge
([#246](#246))
([ebf5552](ebf5552))
* cleanup unused usings 🧹
([#240](#240))
([cdc1bee](cdc1bee))
* **deps:** update actions/upload-artifact action to v4.3.0
([#203](#203))
([0a7e98d](0a7e98d))
* **deps:** update actions/upload-artifact action to v4.3.1
([#233](#233))
([cfaf1c8](cfaf1c8))
* **deps:** update codecov/codecov-action action to v3.1.5
([#209](#209))
([a509b1f](a509b1f))
* **deps:** update codecov/codecov-action action to v3.1.6
([#226](#226))
([a577a80](a577a80))
* **deps:** update dependency coverlet.collector to v6.0.1
([#238](#238))
([f2cb67b](f2cb67b))
* **deps:** update dependency fluentassertions to v6.12.0
([#215](#215))
([2c237df](2c237df))
* **deps:** update dependency microsoft.net.test.sdk to v17.8.0
([#216](#216))
([4cb3ae0](4cb3ae0))
* **deps:** update dependency nsubstitute to v5.1.0
([#217](#217))
([3be76cd](3be76cd))
* **deps:** update dependency openfeature.contrib.providers.flagd to
v0.1.8 ([#211](#211))
([c1aece3](c1aece3))
* **deps:** update xunit-dotnet monorepo
([#236](#236))
([fa25ece](fa25ece))
* Enable Central Package Management (CPM)
([#178](#178))
([249a0a8](249a0a8))
* Enforce coding styles on build
([#242](#242))
([64699c8](64699c8))
* More sln cleanup
([#206](#206))
([bac3d94](bac3d94))
* SourceLink is built-in for .NET SDK 8.0.100+
([#198](#198))
([45e2c86](45e2c86))
* Sync ci.yml with contrib repo
([#196](#196))
([130654b](130654b))
* Sync release.yml with ci.yml following
[#173](#173)
([#195](#195))
([eba8848](eba8848))


### 📚 Documentation

* fix hook ecosystem link
([#229](#229))
([cc6c404](cc6c404))
* update the feature table key
([f8724cd](f8724cd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
arttonoyan pushed a commit to arttonoyan/dotnet-sdk that referenced this pull request Nov 17, 2024
Fixes open-feature#230

---------

Signed-off-by: Roelof Blom <[email protected]>
Signed-off-by: Roelof Blom <[email protected]>
Signed-off-by: Austin Drenski <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Austin Drenski <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
Signed-off-by: Artyom Tonoyan <[email protected]>
arttonoyan pushed a commit to arttonoyan/dotnet-sdk that referenced this pull request Nov 17, 2024
🤖 I have created a release *beep* *boop*
---

##
[1.5.0](open-feature/dotnet-sdk@v1.4.1...v1.5.0)
(2024-03-12)

### 🐛 Bug Fixes

* Add targeting key
([open-feature#231](open-feature#231))
([d792b32](open-feature@d792b32))
* Fix NU1009 reference assembly warning
([open-feature#222](open-feature#222))
([7eebcdd](open-feature@7eebcdd))
* invalid editorconfig
([open-feature#244](open-feature#244))
([3c00757](open-feature@3c00757))

### ✨ New Features

* Flag metadata
([open-feature#223](open-feature#223))
([fd0a541](open-feature@fd0a541))
* implement in-memory provider
([open-feature#232](open-feature#232))
([1082094](open-feature@1082094))

### 🧹 Chore

* bump spec version badge
([open-feature#246](open-feature#246))
([ebf5552](open-feature@ebf5552))
* cleanup unused usings 🧹
([open-feature#240](open-feature#240))
([cdc1bee](open-feature@cdc1bee))
* **deps:** update actions/upload-artifact action to v4.3.0
([open-feature#203](open-feature#203))
([0a7e98d](open-feature@0a7e98d))
* **deps:** update actions/upload-artifact action to v4.3.1
([open-feature#233](open-feature#233))
([cfaf1c8](open-feature@cfaf1c8))
* **deps:** update codecov/codecov-action action to v3.1.5
([open-feature#209](open-feature#209))
([a509b1f](open-feature@a509b1f))
* **deps:** update codecov/codecov-action action to v3.1.6
([open-feature#226](open-feature#226))
([a577a80](open-feature@a577a80))
* **deps:** update dependency coverlet.collector to v6.0.1
([open-feature#238](open-feature#238))
([f2cb67b](open-feature@f2cb67b))
* **deps:** update dependency fluentassertions to v6.12.0
([open-feature#215](open-feature#215))
([2c237df](open-feature@2c237df))
* **deps:** update dependency microsoft.net.test.sdk to v17.8.0
([open-feature#216](open-feature#216))
([4cb3ae0](open-feature@4cb3ae0))
* **deps:** update dependency nsubstitute to v5.1.0
([open-feature#217](open-feature#217))
([3be76cd](open-feature@3be76cd))
* **deps:** update dependency openfeature.contrib.providers.flagd to
v0.1.8 ([open-feature#211](open-feature#211))
([c1aece3](open-feature@c1aece3))
* **deps:** update xunit-dotnet monorepo
([open-feature#236](open-feature#236))
([fa25ece](open-feature@fa25ece))
* Enable Central Package Management (CPM)
([open-feature#178](open-feature#178))
([249a0a8](open-feature@249a0a8))
* Enforce coding styles on build
([open-feature#242](open-feature#242))
([64699c8](open-feature@64699c8))
* More sln cleanup
([open-feature#206](open-feature#206))
([bac3d94](open-feature@bac3d94))
* SourceLink is built-in for .NET SDK 8.0.100+
([open-feature#198](open-feature#198))
([45e2c86](open-feature@45e2c86))
* Sync ci.yml with contrib repo
([open-feature#196](open-feature#196))
([130654b](open-feature@130654b))
* Sync release.yml with ci.yml following
[open-feature#173](open-feature#173)
([open-feature#195](open-feature#195))
([eba8848](open-feature@eba8848))

### 📚 Documentation

* fix hook ecosystem link
([open-feature#229](open-feature#229))
([cc6c404](open-feature@cc6c404))
* update the feature table key
([f8724cd](open-feature@f8724cd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Artyom Tonoyan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Add targeting key to evaluation context
4 participants