Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point actions to remote workflow #372

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Point actions to remote workflow #372

merged 1 commit into from
Nov 19, 2024

Conversation

bparks13
Copy link
Member

This PR updates the Github Actions to point to a remote workflow instead of a local one, allowing for multiple repos that require the same workflow to be updated simultaneously if required.

Note that this update will require changes to the status checks of the current ruleset. Specifically, this PR will not be allowed to merge without overriding the ruleset because this PR is not using the original workflow, and as such the status checks will not be run.

This can be merged successfully by modifying the ruleset to require the new remote workflow actions and removing the original workflow actions, updating the status checks so that it can be merged. However, this could mess up the currently active PRs, because if new commits are pushed to those branches the original workflow will still run (because that is what is saved in the branch), and as such the status checks would fail to run.

Two ways to move forward:

  • Leave this PR for now, and merge all open PRs with the original workflow and original status checks. Then, update the status checks to point to the new workflow, and merge this PR.
  • Update the status checks, allowing this PR to merge successfully. Then, rebase all open PRs to include the new workflow, meaning they will now run against the new status checks

Note that these two approaches can be combined; for example, if two open PRs are ready to be merged, merge them now with the old status checks, then update the ruleset and merge this PR, then rebase the remaining PRs. This is useful if some open PRs will need new commits.

@bparks13 bparks13 added the enhancement This feature already exists but could be improved label Nov 12, 2024
@bparks13 bparks13 added this to the 0.4.1 milestone Nov 12, 2024
@bparks13 bparks13 self-assigned this Nov 12, 2024
@bparks13 bparks13 requested a review from jonnew November 12, 2024 17:16
@bparks13 bparks13 requested a review from cjsha November 19, 2024 18:37
@bparks13 bparks13 merged commit 6828095 into main Nov 19, 2024
8 checks passed
@bparks13 bparks13 deleted the update-actions branch November 19, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This feature already exists but could be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants