Hardcode ConfigureHeartbeat to enabled in ConfigureBreakoutBoard #359
Conversation
jonnew
commented
Oct 29, 2024
jonnew
commented
- Additionally, hardcode its BeatsPerSecond to 100
- Fixes Hardcode heartbeat enable property to true in ConfigureBreakoutBoard #352
- Additionally, hardcode its BeatsPerSecond to 100
There was a problem hiding this comment.
I'm not immediately qualified to evaluate the code as I'm not as familiar with OpenEphys.Onix1. So, I will do this review from the perspective of a user.
I confirm that there is a 100Hz heartbeat that cannot be disabled and its frequency cannot be changed.
Is it worth considering removing it from the properties pane completely? Its label is there with no properties underneath.
It seems like Heartbeat is better as something that should only appear to the user only if the user needs to use it like in a troubleshooting tutorial or something like that. In any case, this is a nitpick, and I will approve the PR anyway.
|
I think that if memory monitor is there, then heartbeat can be there. I don't really like hiding things. I think its fine. |
