Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide PolledBno055 properties in GUI dialogs #314

Open
bparks13 opened this issue Sep 26, 2024 · 2 comments · May be fixed by #369
Open

Hide PolledBno055 properties in GUI dialogs #314

bparks13 opened this issue Sep 26, 2024 · 2 comments · May be fixed by #369
Assignees
Milestone

Comments

@bparks13
Copy link
Member

When a PolledBno055 is under a headstage operator, the AxisMap and AxisSign variables are not displayed in the Bonsai property pane because these are fixed quantities when paired with a specific headstage. However, when they are added to the default property pane in a configuration GUI, these properties are now shown and editable.

image

These variables are not copied back into the main Bonsai window, so there will not be any permanent changes, but if a user changes these values and expects them to make a difference it will seem like a bug.

@bparks13 bparks13 added this to the 0.4.0 milestone Sep 26, 2024
@bparks13 bparks13 self-assigned this Sep 26, 2024
@jonnew
Copy link
Member

jonnew commented Oct 20, 2024

Moving @bparks13 email comments to this discussion

Due to the accessibility of the type converters, I would have to make every single type converter public, as well as make the base class public, if I want to call the converter directly from the Design library

It isn’t a huge amount of code, so I could reimplement it, but that is something we are trying very hard not to do

Question: is it worth exposing all of the type converters in the public interface to make this an easy fix? Or do we just leave it

as-is for now, knowing that a user could potentially see these fields and modify them expecting it to do something when in reality it does nothing?

There is this page on SO showing it might be possible using reflection, if that is something we wanted to do without making the classes public

My opinions

  • I don't think we want to make this public
  • Reflection is probably the way to to go
  • We can release 0.4.0 without this, so if you think its going to hold things up then lets move to 0.5.0

@jonnew
Copy link
Member

jonnew commented Oct 21, 2024

@jonnew jonnew modified the milestones: 0.4.0, 0.5.0 Oct 21, 2024
@bparks13 bparks13 modified the milestones: 0.5.0, 0.4.1 Nov 8, 2024
@jonnew jonnew modified the milestones: 0.4.1, 0.5.0 Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants