You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When a PolledBno055 is under a headstage operator, the AxisMap and AxisSign variables are not displayed in the Bonsai property pane because these are fixed quantities when paired with a specific headstage. However, when they are added to the default property pane in a configuration GUI, these properties are now shown and editable.
These variables are not copied back into the main Bonsai window, so there will not be any permanent changes, but if a user changes these values and expects them to make a difference it will seem like a bug.
The text was updated successfully, but these errors were encountered:
Moving @bparks13 email comments to this discussion
Due to the accessibility of the type converters, I would have to make every single type converter public, as well as make the base class public, if I want to call the converter directly from the Design library
It isn’t a huge amount of code, so I could reimplement it, but that is something we are trying very hard not to do
Question: is it worth exposing all of the type converters in the public interface to make this an easy fix? Or do we just leave it
as-is for now, knowing that a user could potentially see these fields and modify them expecting it to do something when in reality it does nothing?
There is this page on SO showing it might be possible using reflection, if that is something we wanted to do without making the classes public
My opinions
I don't think we want to make this public
Reflection is probably the way to to go
We can release 0.4.0 without this, so if you think its going to hold things up then lets move to 0.5.0
When a
PolledBno055
is under a headstage operator, theAxisMap
andAxisSign
variables are not displayed in the Bonsai property pane because these are fixed quantities when paired with a specific headstage. However, when they are added to the default property pane in a configuration GUI, these properties are now shown and editable.These variables are not copied back into the main Bonsai window, so there will not be any permanent changes, but if a user changes these values and expects them to make a difference it will seem like a bug.
The text was updated successfully, but these errors were encountered: