Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meaningful Synapse.Status.State #42

Open
mgoerens opened this issue Jun 27, 2022 · 0 comments · Fixed by #49
Open

Meaningful Synapse.Status.State #42

mgoerens opened this issue Jun 27, 2022 · 0 comments · Fixed by #49
Labels
improvement related to the improvement of existing capabilities

Comments

@mgoerens
Copy link
Collaborator

Currently, the Synapse.Status.State is simply set to RUNNING when the Reconciler managed to run the happy path once. It's the last thing done by the controller before exiting without requeing (return ctrl.Result{}, nil).

That's not very robust. First we don't check that the pods are actually running, or that Synapse is actually up. Also, subsequent reconciliations (through updates of the CR for instance) might not run successfully. The Synapse.Status.State still would show RUNNING.
@mgoerens mgoerens added the improvement related to the improvement of existing capabilities label Jun 27, 2022
@mgoerens mgoerens mentioned this issue Jun 27, 2022
Merged
This was referenced Jul 19, 2022
Closed
Merged
@mgoerens mgoerens reopened this Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement related to the improvement of existing capabilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use services fqdn instead of IPs for intra Pod communication opdev/synapse-operator
1 participant
@mgoerens