Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not valid json for apps.json file #31

Closed
majkiee opened this issue May 6, 2024 · 5 comments
Closed

Not valid json for apps.json file #31

majkiee opened this issue May 6, 2024 · 5 comments

Comments

@majkiee
Copy link

majkiee commented May 6, 2024

The following line does not pass json validation and parsing. It produces the following error Invalid escape character in string

"Garmin v\xC3\xADvoactive 4S/7.80",

@jamescridland
Copy link
Contributor

That's my fault entirely, sorry.

I have commit rights, but hoped I'd left pull requests for another contributor rather than simply push the requests through. I think I did push one request through in error. I've removed that line.

My apologies.

@majkiee
Copy link
Author

majkiee commented May 6, 2024

it happens to the best of us, thanks for the quick fix 👍🏻

@majkiee
Copy link
Author

majkiee commented May 6, 2024

@jamescridland one recommendation would be to put a github action in place to validate files on PR and commit to stop bad files from coming through.
Example: https://github.com/marketplace/actions/json-yaml-validate

@jamescridland
Copy link
Contributor

I'll let @johnspurlock make that decision. Thank you!

@johnspurlock
Copy link
Contributor

This repo already has such a check - in this case the commit was pushed directly, not as a PR, where the check can stop a bad merge.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants