Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Join Wagtail Nest / merge with Wagtail Math #7

Open
lb- opened this issue Nov 2, 2023 · 16 comments
Open

Discussion: Join Wagtail Nest / merge with Wagtail Math #7

lb- opened this issue Nov 2, 2023 · 16 comments
Assignees

Comments

@lb-
Copy link

lb- commented Nov 2, 2023

Hi. I'm not sure if this is something that would be worth discussing but would there be interest for this package to move to Wagtail Nest. I'm on the Wagtail core team and see that this kind of package looks useful to the community and may need a bit more community support to keep updated.

Additionally, there is a similar package Wagtailmath (uses the MathJax engine) that maybe could be merged together when bringing into the Nest group.

There may even be a desire to support multiple 'text to diagram' engines like Mermaid / Pintora under one package banner.

Let me know if you would be interested. The Wagtail Nest documentation explains what this would mean.

https://github.com/wagtail-nest

@lb-
Copy link
Author

lb- commented Nov 2, 2023

Posted a similar question on Wagtail math. wagtail-nest/wagtail-polymath#11

@ongchi
Copy link
Owner

ongchi commented Nov 2, 2023

Hi. I'm not sure if this is something that would be worth discussing but would there be interest for this package to move to Wagtail Nest. I'm on the Wagtail core team and see that this kind of package looks useful to the community and may need a bit more community support to keep updated.

Additionally, there is a similar package Wagtailmath (uses the MathJax engine) that maybe could be merged together when bringing into the Nest group.

Hi, thank you for your invitation, that sounds good.

There may even be a desire to support multiple 'text to diagram' engines like Mermaid / Pintora under one package banner.

I've been thinking about this before, and I think something like Vega-Lite would also be worth supporting. But it's not urgent to me, I'll just keep it on my list but haven't found some time to implement it yet.

@lb-
Copy link
Author

lb- commented Nov 6, 2023

That's great news @ongchi - would you rather both packages get moved to Wagtail Nest (this one and Wagtail Math) or are you OK to merge this repo's code into a new repo/project that will support both MathJax and Katex?

My thinking is that will be easier for a community, including yourself and the author of Wagtail Math to have one text to diagram/math package instead of multiple.

Either way, you would still be an author and have permissions to merge in the new repo but a few of us would have to help each other to get the code into a place that aligns with the Wagtail cookie cutter approach.

@ongchi
Copy link
Owner

ongchi commented Nov 10, 2023

Hi @lb- ,

I think it's reasonable to merge this package into Wagtail Math and make the package support both KaTeX and MathJax rendering engines. This could be done by providing separate components or a config variable to let users decide.
From my vague memory, rich text fields save both raw text and rendered HTML to the database, correct me if I'm wrong. So maybe this should be provided as separate components.
I don't have time recently. Anyone willing to contribute is also welcome. Alternatively, I could find a weekend, maybe in December, to get this done.

@lb-
Copy link
Author

lb- commented Nov 10, 2023

Thank you for being up for a merge of functionality, we would 100% love to get your support in this and hopefully with a few others from the community involved it wont be as difficult to keep the project maintained as Wagtail continues to release changes.

As the next step I will raise a new discussion on the Wagtail Nest repo, get feedback on the naming and then we can working through the migration/merging.

@lb-
Copy link
Author

lb- commented Nov 10, 2023

https://github.com/orgs/wagtail-nest/discussions/3 discussion raised - would love any input on naming and process if you have a bit more time to chime in @ongchi

@lb-
Copy link
Author

lb- commented Nov 29, 2023

@ongchi - quick update.

Wagtail-math has now moved to https://github.com/wagtail-nest/wagtail-polymath/

I have invited to you to be a member of that repo if you are up for helping merge your code into that repo (we will work out the details of this a bit later).

@lb-
Copy link
Author

lb- commented Mar 16, 2024

@ongchi just wondering if you are still keen on being involved with this migration/merging in some form.

@ongchi ongchi self-assigned this Mar 17, 2024
@ongchi
Copy link
Owner

ongchi commented Mar 17, 2024

@ongchi just wondering if you are still keen on being involved with this migration/merging in some form.

Oh! Sorry, I completely forgot about this project for a while.
I think I can merge this codebase into wagtail-polymath at least, and support both MathJax and KaTeX backends.

@lb-
Copy link
Author

lb- commented Mar 24, 2024

Great @ongchi I have added you as a maintainer on the repo.

Not sure on how we can coordinate next steps, we do have a Wagtail package guidelines which we would probably want to start to work towards at some point.

https://github.com/wagtail/wagtail/wiki/Python-Package-Maintenance-Guidelines

@ongchi
Copy link
Owner

ongchi commented Mar 24, 2024

Here is my short-term plan for this project:

  1. Merge wagtail-katex codebase into wagtail-polymath first, start from this branch, and make sure everything works fine.
  2. Apply overall project style using Wagtail Cookie Cutter.
  3. Measure the implementation of the guidelines.

@lb-
Copy link
Author

lb- commented Apr 23, 2024

Awesome

@zerolab
Copy link

zerolab commented Jun 21, 2024

@ongchi fwiw, I've opened wagtail-nest/wagtail-polymath#12 to add support for Wagtail 5.2+. It also aligns it to the wagtail-nest guidelines.

I did not rename it to wagtail_polymath yet, but it is worth syncing up the efforts to merge things

@ongchi
Copy link
Owner

ongchi commented Jun 24, 2024

Hi @zerolab, many thanks for your effort.

The wagtail-polymath's render engine is different from wagtail-katex, so before merging the two projects into one, I did some experiments to support both MathJax and KaTeX for wagtail-polymath and wagtail-katex.

I believe we could start to merge this project into wagtail-polymath with a few modifications after wagtail-nest/wagtail-polymath#12 is merged.

@zerolab
Copy link

zerolab commented Jun 24, 2024

Thank you @ongchi

wagtail-nest/wagtail-polymath#12 is now merged

@lb-
Copy link
Author

lb- commented Jun 26, 2024

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants