Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waitFor is deprecated... #5

Open
plato79 opened this issue Apr 7, 2024 · 3 comments
Open

waitFor is deprecated... #5

plato79 opened this issue Apr 7, 2024 · 3 comments

Comments

@plato79
Copy link

plato79 commented Apr 7, 2024

I'm getting this error when trying to get running containers:

Synchronous waiting using dart:cli waitFor and C API Dart_WaitForEvent is deprecated and disabled by default. This feature will be fully removed in Dart 3.4 release. You can currently still enable it by passing --enable_deprecated_wait_for to the Dart VM. See https://dartbug.com/52121.
dart:cli                                              waitFor
package:dcli/src/util/wait_for_ex.dart 38:17          waitForEx
package:dcli/src/functions/which.dart 97:5            which
package:dcli/src/util/runnable_process.dart 532:21    RunnableProcess._searchForCommandExtension
package:dcli/src/util/runnable_process.dart 245:21    RunnableProcess.start
package:dcli/src/util/runnable_process.dart 178:7     RunnableProcess.run
package:dcli/src/functions/run.dart 255:19            start
package:dcli/src/util/string_as_process.dart 201:11   StringAsProcess.start
package:docker2/src/docker_cli/docker.dart 138:10     Docker._dockerRun
package:docker2/src/docker_cli/docker.dart 150:14     dockerRun
package:docker2/src/docker_cli/containers.dart 31:19  Containers.containers
package:docker2/src/docker_cli/docker.dart 129:20     Docker.containers

I think dcli used by docker2 is using deprecated waitFor function. Latest version resolves this problem. Please update pubspec.yaml

@bsutton
Copy link
Contributor

bsutton commented Apr 7, 2024 via email

@plato79
Copy link
Author

plato79 commented Apr 7, 2024

I did a dirty patch, so just use this for dcli:

dcli:
git:
url: https://github.com/wilinz/dcli
path: dcli
ref: master

the functions/which.dart is changed and it's not usign waitFor anymore.

@bsutton
Copy link
Contributor

bsutton commented Apr 16, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants