Update bin/dwhich.dart?

[tsavo-at-pieces]

Hey there @bsutton -- getting into all of this.

Could you confirm that dwhich.dart needs to be updated?

It seems to be still using an old Args class from an earlier version of DCLI (3.x.x?)

It also seems that the new ExitException in DCLI 4.x found here:
https://github.com/onepub-dev/dcli/blob/master/dcli_sdk/lib/src/util/exit.dart
or here:
https://github.com/onepub-dev/dcli/blob/master/dcli_sdk/lib/src/util/exceptions.dart

And perhaps a related class here:
https://github.com/onepub-dev/dcli/blob/master/dcli_core/lib/src/util/dcli_exception.dart
and here:
https://github.com/onepub-dev/dcli/blob/master/dcli_core/lib/src/util/run_exception.dart

Let me know if this is relevant/related, happy to get this updated with a bit of direction!

Cheers,
-Tsavo

[bsutton]

I've just released dcli-scripts 3.3.0 - see if that fixes your problem.

…

On Tue, Mar 12, 2024 at 3:17 AM Tsavo Knott ***@***.***> wrote: Hey there @bsutton <https://github.com/bsutton> -- getting into all of this. Could you confirm that dwhich.dart <https://github.com/onepub-dev/dcli_scripts/blob/master/bin/dwhich.dart> needs to be updated? It seems to be still using an old Args class from an earlier version of DCLI (3.x.x?) It also seems that the new ExitException in DCLI 4.x found here: https://github.com/onepub-dev/dcli/blob/master/dcli_sdk/lib/src/util/exit.dart or here: https://github.com/onepub-dev/dcli/blob/master/dcli_sdk/lib/src/util/exceptions.dart And perhaps a related class here: https://github.com/onepub-dev/dcli/blob/master/dcli_core/lib/src/util/dcli_exception.dart and here: https://github.com/onepub-dev/dcli/blob/master/dcli_core/lib/src/util/run_exception.dart Let me know if this is relevant/related, happy to get this updated with a bit of direction! Cheers, -Tsavo — Reply to this email directly, view it on GitHub <#3>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAG32OGK73P5G4OPTIZN423YXXKKZAVCNFSM6AAAAABEQT2WNKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE3TSNJUGQ2DONA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[tsavo-at-pieces]

Just got it all updated with the 3.3.0 source code.

It seems that the dwhich.dart is one of the only files thats looking for a args.dart file at package path import 'package:dcli_scripts/src/dwhich/args.dart'; and a exit_exception.dart at package path import 'package:dcli_scripts/src/dwhich/exit_exception.dart';

I'm looking at it in this file specifically: packages/dcli_scripts/bin/dwhich.dart could it be accidentally .gitignored here?