Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purpose of maxHeight? #12

Open
tehandyb opened this issue Dec 12, 2016 · 0 comments
Open

Purpose of maxHeight? #12

tehandyb opened this issue Dec 12, 2016 · 0 comments

Comments

@tehandyb
Copy link
Contributor

Hey I was wondering what the purpose of the max height property was? In my fork I ended up taking it out DevTech-ADVISE#12
I took it out because of an issue where when the fullHeight gets smaller than the max height, the height calculation was slightly innaccurate(for reasons I couldn't figure out), causing some overflow to occur.

I just wanted to check to make sure it wouldn't break other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant