Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new copy signatures for shp and mhp #640

Closed
wants to merge 3 commits into from

Conversation

haichangsi
Copy link
Contributor

remove ifdef BENCH_SHP in sort

@haichangsi haichangsi self-assigned this Nov 15, 2023
@haichangsi haichangsi linked an issue Nov 15, 2023 that may be closed by this pull request
@haichangsi haichangsi marked this pull request as ready for review November 15, 2023 13:37
Copy link
Contributor

@mateuszpn mateuszpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not exactly what we wanted. In std::ranges, and in distributed ranges, most APIs accept range variable as an argument. There is no need to provide both begin() and end() if we want to make an operation on the whole range (there should be still the option in overload to provide begin() and end()).
Adding the new API with the arguments 'first' and 'last' to mhp::copy() is nice and useful, keep it. However, we need also change in opposite direction: shp::copy(range in, iterator out). The example should read: xhp::copy(local, rng::begin(*a)); both in mhp and shp.

@haichangsi haichangsi changed the title added a new mhp::copy signature added new copy signatures for shp and mhp Nov 29, 2023
Copy link
Contributor

@mateuszpn mateuszpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for new API

@rscohn2 rscohn2 closed this Dec 18, 2023
@haichangsi haichangsi deleted the signatures branch April 29, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add missing copy functins to shp&mhp
3 participants