BUG: captcha factory missing in constructor of auth/provider/oneall.php

[RonaldKools]

PhpBB3.3.x has some extra parameters in the constructor of phpbb/auth/provider/db.php:

public function __construct(factory $captcha_factory, config $config, driver_interface $db, manager $passwords_manager, request_interface $request, user $user, $phpbb_root_path, $php_ext)

However, the captcha factory is missing in the constructor of /auth/provider/oneall.php:

public function __construct(\phpbb\db\driver\driver_interface $db, \phpbb\config\config $config, \phpbb\passwords\manager $passwords_manager, \phpbb\request\request $request, \phpbb\user $user, \Symfony\Component\DependencyInjection\ContainerInterface $phpbb_container, $phpbb_root_path, $php_ext)

It extends db.php, causing a 500 error when you get the spam protection captcha for incorrectly logging in for 3 times:

PHP Fatal error: Uncaught Error: Call to a member function get_instance() on null in /var/www/html/phpBB3.3.1/phpbb/auth/provider/db.php:179