Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add float as SDF data subtype #92

Open
mjkoster opened this issue Nov 16, 2019 · 1 comment
Open

Add float as SDF data subtype #92

mjkoster opened this issue Nov 16, 2019 · 1 comment
Assignees
@mjkoster
Labels
bug Something isn't working Resolved

Comments

@mjkoster
Copy link
Contributor

mjkoster commented Nov 16, 2019 •
edited
Loading

We are using "float" in the IPSO models as a data subtype. I believe we intended to allow this and many more, but ATM we only have bytestring and unixtime.

Propose to add float for now, and make another issue to drive discussion of subtypes in general
@mjkoster mjkoster self-assigned this Nov 16, 2019
@mjkoster mjkoster added the bug Something isn't working label Nov 16, 2019
mjkoster added a commit that referenced this issue Jan 17, 2020
@mjkoster
type changes
b2db631 
enum items can be any type (issue #100)
add float subtype (issue #92)
@mjkoster mjkoster mentioned this issue Jan 17, 2020
Merged
@mjkoster
Copy link
Contributor Author

PR #101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjkoster mjkoster

Labels
bug Something isn't working Resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mjkoster