feat: make GitOid display print URL format #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the Display impl for GitOid printed some but not all of the data associated with the URL representation. This commit changes that to just print the URL representation, and updates the GitOid::url method to delegate to `to_string` which delegates to that `Display` impl. Signed-off-by: Andrew Lilley Brinker <[email protected]>
alilleybrinker
force-pushed
the
alilleybrinker/gitoid-display
branch
from
ba3b244
to
c0edcd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the Display impl for GitOid printed some but not all of the
data associated with the URL representation. This commit changes that to
just print the URL representation, and updates the GitOid::url method
to delegate to
to_stringwhich delegates to thatDisplayimpl.Signed-off-by: Andrew Lilley Brinker [email protected]