feat: simplify GitOid crate substantially. #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alilleybrinker
force-pushed
the
alilleybrinker/simplify-gitoid
branch
from
5d0c7e2
to
7b36cb6
Compare
This commit comments out the FFI for the GitOid crate, which will be repurposed into an FFI for the OmniBOR crate. This will avoid a known issue with cbindgen involving macro expansion of crates used as dependencies in the same workspace, and will also more directly reflect our intended use of the code in this workspace anyway. We want to provide a basis for cross-language OmniBOR implementations, not really for cross-language GitOID implementations, for which libgit2 should already be fine. This commit also simplifies the trait bounds on the GitOID type, and modifies some existing imports from `std` to `core`. Signed-off-by: Andrew Lilley Brinker <[email protected]>
alilleybrinker
force-pushed
the
alilleybrinker/simplify-gitoid
branch
from
7b36cb6
to
bab0282
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit comments out the FFI for the GitOid crate, which
will be repurposed into an FFI for the OmniBOR crate. This will avoid
a known issue with cbindgen involving macro expansion of crates used
as dependencies in the same workspace, and will also more directly
reflect our intended use of the code in this workspace anyway. We want
to provide a basis for cross-language OmniBOR implementations, not
really for cross-language GitOID implementations, for which libgit2
should already be fine.
This commit also simplifies the trait bounds on the GitOID type, and
modifies some existing imports from
stdtocore.Signed-off-by: Andrew Lilley Brinker [email protected]