feat: Misc. API and docs cleanups

Signed-off-by: Andrew Lilley Brinker <[email protected]>

Author: alilleybrinker

omnibor/benches/benchmark.rs

@@ -25,11 +25,11 @@ fn bench_rustcrypto_sha256_small(c: &mut Criterion) {
 
     let name = "OmniBOR RustCrypto SHA-256 11B";
     let input = b"hello world";
-    set_hash_provider::<Sha256, RustCrypto>().unwrap();
+    set_hash_provider::<Sha256, RustCrypto>();
 
     c.bench_function(name, |b| {
         b.iter(|| {
-            let _ = ArtifactId::<Sha256>::new(black_box(input)).unwrap();
+            let _ = ArtifactId::sha256(black_box(input)).unwrap();
         })
     });
 }
@@ -40,11 +40,11 @@ fn bench_boring_sha256_small(c: &mut Criterion) {
 
     let name = "OmniBOR BoringSSL SHA-256 11B";
     let input = b"hello world";
-    set_hash_provider::<Sha256, BoringSsl>().unwrap();
+    set_hash_provider::<Sha256, BoringSsl>();
 
     c.bench_function(name, |b| {
         b.iter(|| {
-            let _ = ArtifactId::<Sha256>::new(black_box(input));
+            let _ = ArtifactId::sha256(black_box(input));
         })
     });
 }
@@ -55,11 +55,11 @@ fn bench_openssl_sha256_small(c: &mut Criterion) {
 
     let name = "OmniBOR OpenSSL SHA-256 11B";
     let input = b"hello world";
-    set_hash_provider::<Sha256, OpenSsl>().unwrap();
+    set_hash_provider::<Sha256, OpenSsl>();
 
     c.bench_function(name, |b| {
         b.iter(|| {
-            let _ = ArtifactId::<Sha256>::new(black_box(input));
+            let _ = ArtifactId::sha256(black_box(input));
         })
     });
 }
@@ -70,11 +70,11 @@ fn bench_rustcrypto_sha256_large(c: &mut Criterion) {
 
     let name = "OmniBOR RustCrypto SHA-256 100MB";
     let input = &[0; 1024 * 1024 * 100]; // 100 MB
-    set_hash_provider::<Sha256, RustCrypto>().unwrap();
+    set_hash_provider::<Sha256, RustCrypto>();
 
     c.bench_function(name, |b| {
         b.iter(|| {
-            let _ = ArtifactId::<Sha256>::new(black_box(input)).unwrap();
+            let _ = ArtifactId::sha256(black_box(input)).unwrap();
         })
     });
 }
@@ -85,11 +85,11 @@ fn bench_boring_sha256_large(c: &mut Criterion) {
 
     let name = "OmniBOR BoringSSL SHA-256 100MB";
     let input = &[0; 1024 * 1024 * 100]; // 100 MB
-    set_hash_provider::<Sha256, BoringSsl>().unwrap();
+    set_hash_provider::<Sha256, BoringSsl>();
 
     c.bench_function(name, |b| {
         b.iter(|| {
-            let _ = ArtifactId::<Sha256>::new(black_box(input)).unwrap();
+            let _ = ArtifactId::sha256(black_box(input)).unwrap();
         })
     });
 }
@@ -100,11 +100,11 @@ fn bench_openssl_sha256_large(c: &mut Criterion) {
 
     let name = "OmniBOR OpenSSL SHA-256 100MB";
     let input = &[0; 1024 * 1024 * 100]; // 100 MB
-    set_hash_provider::<Sha256, OpenSsl>().unwrap();
+    set_hash_provider::<Sha256, OpenSsl>();
 
     c.bench_function(name, |b| {
         b.iter(|| {
-            let _ = ArtifactId::<Sha256>::new(black_box(input)).unwrap();
+            let _ = ArtifactId::sha256(black_box(input)).unwrap();
         })
     });
 }

omnibor/src/artifact_id/identify_async.rs

@@ -1,7 +1,7 @@
 use crate::{
     error::ArtifactIdError, gitoid::internal::gitoid_from_async_reader,
-    hash_algorithm::HashAlgorithm, hash_provider::registry::get_hash_provider_async,
-    object_type::Blob, util::clone_as_boxstr::CloneAsBoxstr, ArtifactId,
+    hash_algorithm::HashAlgorithm, hash_provider::registry::get_hash_provider, object_type::Blob,
+    util::clone_as_boxstr::CloneAsBoxstr, ArtifactId,
 };
 use std::{
     ffi::{OsStr, OsString},
@@ -92,7 +92,7 @@ where
     H: HashAlgorithm,
 {
     async fn identify_async(self) -> Result<ArtifactId<H>, ArtifactIdError> {
-        let mut digester = get_hash_provider_async().await.digester();
+        let mut digester = get_hash_provider().digester();
         let gitoid = gitoid_from_async_reader::<H, Blob, _>(&mut *digester, self).await?;
         Ok(ArtifactId::from_gitoid(gitoid))
     }
@@ -113,7 +113,7 @@ where
     R: AsyncRead + AsyncSeek + Unpin,
 {
     async fn identify_async(self) -> Result<ArtifactId<H>, ArtifactIdError> {
-        let mut digester = get_hash_provider_async().await.digester();
+        let mut digester = get_hash_provider().digester();
         let gitoid = gitoid_from_async_reader::<H, Blob, _>(&mut *digester, self).await?;
         Ok(ArtifactId::from_gitoid(gitoid))
     }

omnibor/src/error.rs

@@ -1,9 +1,7 @@
 //! Error types for working with `ArtifactId`s and `InputManifest`s.
 
 pub(crate) mod artifact_id_error;
-pub(crate) mod hash_provider_error;
 pub(crate) mod input_manifest_error;
 
 pub use crate::error::artifact_id_error::ArtifactIdError;
-pub use crate::error::hash_provider_error::HashProviderError;
 pub use crate::error::input_manifest_error::InputManifestError;

omnibor/src/error/hash_provider_error.rs

@@ -5,7 +5,6 @@ use {
     std::io::Error as IoError,
 };
 
-use crate::error::HashProviderError;
 #[cfg(doc)]
 use crate::{artifact_id::ArtifactId, input_manifest::InputManifest};
 
@@ -155,9 +154,6 @@ pub enum InputManifestError {
 
     /// Failed to initialize hash providers.
     FailedToInitHashProviders,
-
-    /// Hash provider errors.
-    HashProviderError(HashProviderError),
 }
 
 impl InputManifestError {
@@ -235,7 +231,6 @@ impl Display for InputManifestError {
             },
             InputManifestError::InvalidCharInManifest => write!(f, "invalid character in manifest"),
             InputManifestError::FailedToInitHashProviders => write!(f, "failed to initialize hash providers"),
-            InputManifestError::HashProviderError(source) => write!(f, "{source}"),
         }
     }
 }
@@ -284,7 +279,6 @@ impl Error for InputManifestError {
             InputManifestError::FailedStorageCleanup(_, source) => Some(source),
             InputManifestError::CantRemoveManifest(source) => Some(source),
             InputManifestError::CantEmbedInTarget(_, source) => Some(source),
-            InputManifestError::HashProviderError(source) => Some(source),
         }
     }
 }
@@ -294,9 +288,3 @@ impl From<ArtifactIdError> for InputManifestError {
         InputManifestError::ArtifactIdError(value)
     }
 }
-
-impl From<HashProviderError> for InputManifestError {
-    fn from(value: HashProviderError) -> Self {
-        InputManifestError::HashProviderError(value)
-    }
-}