Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review feedback - LendingPool contract #170

Open
redlarva opened this issue Feb 15, 2023 · 0 comments
Open

Code review feedback - LendingPool contract #170

redlarva opened this issue Feb 15, 2023 · 0 comments
Assignees

Comments

@redlarva
Copy link
Member

  • Validate reserve data is not empty:
    In our current implementation, some of the methods such as redeem, borrow, repay, deposit, and liquidationCall do not validate whether the reserve data is empty before proceeding with the function. This can lead to potential errors, such as null pointer exceptions. To avoid these issues, we will add a validation check to ensure that the reserve data is not empty before proceeding with any of these methods.

  • Use caller address as reserve for liquidation:
    In our liquidationCall method, we are currently using a params value to determine the address of the reserve which we can avoid and use caller address to identify reserve.

@redlarva redlarva self-assigned this Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant