Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Review Feedback - LendingPoolCore contract #169

Open
redlarva opened this issue Feb 15, 2023 · 0 comments
Open

Code Review Feedback - LendingPoolCore contract #169

redlarva opened this issue Feb 15, 2023 · 0 comments
Assignees

Comments

@redlarva
Copy link
Member

Validating Reserve, Removing fallback Method, and Sanitizing tokenFallback

  • Validate Reserve for getReserveAvailableLiquidity Params:
    getReserveAvailableLiquidity method doesn't validate the reserve parameter. To mitigate this risk, we add a validation check to ensure that the reserve parameter is a valid address before proceeding with the function.

  • Remove Fallback Method to receive ICX:
    In our current implementation, we have a fallback method that can receive ICX payments. As LPC does not need to receive any ICX we can remove this method.

  • Sanitize tokenFallback to receive only from valid Tokens:
    Our tokenFallback method should only accept tokens from valid sources. We should add a check to ensure that the tokens being sent are from a trusted source.

@redlarva redlarva self-assigned this Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant