Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group imports #6

Open
akshar-raaj opened this issue Jul 14, 2014 · 6 comments
Open

Group imports #6

akshar-raaj opened this issue Jul 14, 2014 · 6 comments

Comments

@akshar-raaj
Copy link

In users/views.py I find django and user imports mixed. Follow the convention:

python imports
python imports

django imports
django imports

project specific imports
project specific imports
@akshar-raaj
Copy link
Author

This is not done, I guess you will take an action on this.

@akshar-raaj
Copy link
Author

What's the status on this?

@omkarvijay5
Copy link
Owner

I have made changes to views.py models.py to follow the following
conventions

Imports
Django Imports
App imports

On Fri, Aug 1, 2014 at 11:20 AM, Akshar Raaj [email protected]
wrote:

What's the status on this?

—
Reply to this email directly or view it on GitHub
#6 (comment)
.

@omkarvijay5
Copy link
Owner

Done

@akshar-raaj
Copy link
Author

There should be a blank line between different group of imports.

@omkarvijay5
Copy link
Owner

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akshar-raaj @omkarvijay5