From 57df1d35fe2e9e280dc7b35d45522038ec204c1f Mon Sep 17 00:00:00 2001 From: Pawel Gebal Date: Wed, 26 Aug 2020 12:07:59 +0200 Subject: [PATCH] refactor: delete rlpOutputTx from ExitStarted event and inputTxs from InFlightExitStarted event --- .../exits/payment/controllers/PaymentStartInFlightExit.sol | 2 -- .../exits/payment/controllers/PaymentStartStandardExit.sol | 6 ++---- .../payment/controllers/PaymentStartInFlightExit.test.js | 1 - .../payment/controllers/PaymentStartStandardExit.test.js | 3 --- 4 files changed, 2 insertions(+), 10 deletions(-) diff --git a/plasma_framework/contracts/src/exits/payment/controllers/PaymentStartInFlightExit.sol b/plasma_framework/contracts/src/exits/payment/controllers/PaymentStartInFlightExit.sol index 418d8959a..57cc29464 100644 --- a/plasma_framework/contracts/src/exits/payment/controllers/PaymentStartInFlightExit.sol +++ b/plasma_framework/contracts/src/exits/payment/controllers/PaymentStartInFlightExit.sol @@ -39,7 +39,6 @@ library PaymentStartInFlightExit { bytes32 indexed txHash, bytes inFlightTx, uint256[] inputUtxosPos, - bytes[] inputTxs, bytes[] inFlightTxWitnesses ); @@ -114,7 +113,6 @@ library PaymentStartInFlightExit { txHash: startExitData.inFlightTxHash, inFlightTx: args.inFlightTx, inputUtxosPos: args.inputUtxosPos, - inputTxs: args.inputTxs, inFlightTxWitnesses: args.inFlightTxWitnesses }); } diff --git a/plasma_framework/contracts/src/exits/payment/controllers/PaymentStartStandardExit.sol b/plasma_framework/contracts/src/exits/payment/controllers/PaymentStartStandardExit.sol index fce52ca8d..699428268 100644 --- a/plasma_framework/contracts/src/exits/payment/controllers/PaymentStartStandardExit.sol +++ b/plasma_framework/contracts/src/exits/payment/controllers/PaymentStartStandardExit.sol @@ -44,8 +44,7 @@ library PaymentStartStandardExit { event ExitStarted( address indexed owner, uint168 exitId, - uint256 utxoPos, - bytes rlpOutputTx + uint256 utxoPos ); /** @@ -95,8 +94,7 @@ library PaymentStartStandardExit { emit ExitStarted({ owner: msg.sender, exitId: data.exitId, - utxoPos: args.utxoPos, - rlpOutputTx: args.rlpOutputTx + utxoPos: args.utxoPos }); } diff --git a/plasma_framework/test/src/exits/payment/controllers/PaymentStartInFlightExit.test.js b/plasma_framework/test/src/exits/payment/controllers/PaymentStartInFlightExit.test.js index a6e2721fe..ad7859f11 100644 --- a/plasma_framework/test/src/exits/payment/controllers/PaymentStartInFlightExit.test.js +++ b/plasma_framework/test/src/exits/payment/controllers/PaymentStartInFlightExit.test.js @@ -248,7 +248,6 @@ contract('PaymentStartInFlightExit', ([_, alice, richFather, carol]) => { const logs = PaymentStartInFlightExit.decodeLogs(txReceipt.logs); const event = logs.filter(e => e.event === 'InFlightExitStarted')[0]; - expect(event.args.inputTxs).to.have.ordered.members(this.args.inputTxs); expect(event.args.inFlightTxWitnesses).to.have.ordered.members(this.args.inFlightTxWitnesses); const inputUtxosPos = this.args.inputUtxosPos.map(utxoPos => new BN(utxoPos)); diff --git a/plasma_framework/test/src/exits/payment/controllers/PaymentStartStandardExit.test.js b/plasma_framework/test/src/exits/payment/controllers/PaymentStartStandardExit.test.js index 1ec8ec13d..1c473155a 100644 --- a/plasma_framework/test/src/exits/payment/controllers/PaymentStartStandardExit.test.js +++ b/plasma_framework/test/src/exits/payment/controllers/PaymentStartStandardExit.test.js @@ -404,7 +404,6 @@ contract('PaymentStartStandardExit', ([_, outputOwner, nonOutputOwner]) => { owner: outputOwner, exitId, utxoPos: new BN(args.utxoPos), - rlpOutputTx: args.rlpOutputTx, }, ); }); @@ -441,7 +440,6 @@ contract('PaymentStartStandardExit', ([_, outputOwner, nonOutputOwner]) => { owner: outputOwner, exitId: exitId1, utxoPos: new BN(args[0].utxoPos), - rlpOutputTx: args[0].rlpOutputTx, }, ); @@ -463,7 +461,6 @@ contract('PaymentStartStandardExit', ([_, outputOwner, nonOutputOwner]) => { owner: outputOwner, exitId: exitId2, utxoPos: new BN(args[1].utxoPos), - rlpOutputTx: args[1].rlpOutputTx, }, ); });