Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[COMMON] PR to ESPHome Code Base #9

Open
bzumik1 opened this issue Oct 2, 2023 · 3 comments
Open

[COMMON] PR to ESPHome Code Base #9

bzumik1 opened this issue Oct 2, 2023 · 3 comments
Labels
maybe_later

Comments

@bzumik1
Copy link
Contributor

bzumik1 commented Oct 2, 2023

Hi, is there plan to merge this component to ESPHome code base? I think it would be nice touch. I fully understand that we need to test it properly first but I think that with this functionality we have right now it would be nice 1.0 version.
@lanwin
Copy link
Collaborator

lanwin commented Oct 3, 2023

I am absolutely not sure about that. I did not know what requirements they have to do that. Maybe later. But for now I would like to focus on adding some features and fixing issues.

@bzumik1
Copy link
Contributor Author

bzumik1 commented Oct 3, 2023

I totally agree, I just wanted to open this so at point when we will feel comfortable it si working we would create PR to ESPHome. I have seen some other AC brands are already there. But this would be just nice thing to have, I agree it has lowest priority.

@bzumik1 bzumik1 changed the title PR to ESPHome Code Base [COMMON] PR to ESPHome Code Base Oct 5, 2023
@TCB13
Copy link
Contributor

TCB13 commented Dec 4, 2023

+1 on this. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maybe_later
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lanwin @TCB13 @bzumik1