Protocol - is unsigned representation right? #238
brazoayeye
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I just tried to change my repo to handle correctly signed representations for temperatures.
brazoayeye@c4800f6
In my application all works well without problems, all recived values are much smaller than int16_t max size
In other applications ( #213 (reply in thread) ) it solves some problems or reduce yaml size.
Is there a reason to handle values as unsigned int?
Idk what are samsung specs, nor if some used values (maybe counters?) collect values bigger than 2^15. Maybe counter also uses longer variables, because if you reach the 2^15 value it's probable you'll reach the 2^16.
Is there a reason to keep variables and long variables as unsigned?
Thanks
Beta Was this translation helpful? Give feedback.
All reactions