-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Left-hand sidebar doesn't scroll #1041
Comments
Check out the scrolling-sidebar branch for an implementation of "scrolling sidebar" (you may need to hard-refresh or clear cache to pick up the new stylesheet after switching). The sidebar already has/had some styling for a scrollbar despite not having one... we'll have to touch base with @kimisgold to see if we can remember if this was previously done and taken out, or assumed to be in place, or what. |
This looks good! Can we also add some bottom padding to the navigation ul - there is usually an overlay on that part of the browser window when your mouse is over a link. ![]() Should look like
Next question: What determines the display order of the sidebar entries? It would be nice to be able to organize them. (Also an @aviannamiller thought.) |
Building on the question about display order and allowing list organization, I am curious how admin customization could be expanded here. Could there be a way for admins to "star/favorite" and "hide" modules to prioritize according to need and use (of course a relevant question for S, as well)? |
I've added some padding to the navbar, so it should be clearing the browser's url hover content now. I'm interested in admin customization, especially for the left nav that can get pretty crowded with plugins. We could probably open up a discussion in a new issue to figure out what that might look like as well as the technical logistics involved. |
The browsers move that popup out of the way if the thing you're hovering is where the popup would be, right? Does having it overlap cause a problem actually? |
Ah, yes, the sidebar itself should be top-pinned and only ~95% or so of the container height. A better solution than just adding padding under the last entry. |
I moved the padding and scrolling around so it should always be present. I haven't increased the size of the padding but we could also do that. |
This is much better! Could we try increasing the padding to 36px to match the height of the list items? That seems to help the most with tabbing issues where the padding in its current state on certain page zooms partially covers list items while they have focus (ex. 100% on Firefox). |
As pointed out by @aviannamiller, the left-hand drawer with all the plugin links doesn't scroll, even when the rest of the page is scrolling. Any overflow is hidden, which is a problem when you have a lot of plugins.
This appears to be true on both Firefox and Chrome. We're both on the master branch (3.2-dev4).
Should this have a separate scroll within the sidebar, or should the whole page scroll according to its height? For that we could just add whitespace as needed between the content and the footer.
The text was updated successfully, but these errors were encountered: