Add try/except around submit() to handle failures #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jburel
force-pushed
the
try_except_submit
branch
from
860805b to
a5fa83c
Compare
|
@will-moore could you fix the flake8 issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11.
This first commit does the minimum requested by @pwalczysko of simply not failing if the DiskUsage submit failed.
Happy to also add an option to specify the timeout as suggested by @joshmoore.
But just wondering what the
500loops means at https://github.com/ome/omero-demo-cleanup/blob/main/src/omero_demo_cleanup/library.py#L118 ?Is that 500 pings to wait for a result - and how long between each one?
E.g. If a user were to enter their own value, would this look like a
--loopsparameter? Would anyone know what that means? Or would we go for--secondsparameter for how long to wait? And how does this map toloops?