Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resave throws unspecific warning and does nothing #44

Closed
constantinpape opened this issue Aug 30, 2024 · 5 comments
Closed

Resave throws unspecific warning and does nothing #44

constantinpape opened this issue Aug 30, 2024 · 5 comments

Comments

@constantinpape
Copy link

I want to convert data from ngff v0.4 to the challenge submission format, but the resave command only creates the output root directory without converting any data. It also throws a warning:

$ ome2024-ngff-challenge resave --cc-by ngff-v2/Platynereis-H2B-TL.ome.zarr ngff-v3/Platynereis-H2B-TL.ome.zarr --output-overwrite

throws

2024-08-30 17:11:09.021 WARNING  no convertible metadata: KeysView(<zarr.attributes.Attributes object at 0x7fe2a1b07350>)

I assume that is because the file is not fully spec compliant with the v0.4 spec (it comes from a custom pipeline), or that the converter makes some additional assumptions not part of the spec.

However, I can't determine what the issue is since the warning thrown here is quite unspecific and since I did not find another way to validate the file yet, see also ome/ome-zarr-py#400.

The file in question is available here: https://drive.google.com/file/d/1WSHQWkOXUfSBahOJdVzrKbj91mczKhZP/view?usp=sharing

@joshmoore
Copy link
Member

If I run:

ome_zarr view Platynereis-H2B-TL.ome.zarr/c0-t0/

I see the following:

image

i.e. two separate issues:

  • the OME-Zarr part starts one level down (no problem really)
  • it has the wrong dimension separator

@will-moore
Copy link
Member

The dimension separator is not a problem.
However, it did complain if I didn't specify a shard size. This works...

$ ome2024-ngff-challenge resave --cc-by Platynereis-H2B-TL.ome.zarr/c0-t0 zarr_v3/Platynereis-H2B-TL.ome.zarr --output-overwrite --output-shards=512,512,512

Then view it with:

$ ome_zarr view zarr_v3/Platynereis-H2B-TL.ome.zarr

Chunks are loading OK etc:

Screenshot 2024-08-30 at 16 37 20

@constantinpape
Copy link
Author

Thanks for the replies @joshmoore and @will-moore

Regarding the points you raised:

  • I can change the dimension separator if needed.
  • I tried the command with output shards @will-moore , but I still get the same issue as before. What version of the converter tool are you using? I just used the version installed via pip; maybe there are some more recent changes and I should use the version from main instead?

@will-moore
Copy link
Member

I'm using the released version (or a git branch that is effectively the same).
Did you change your command to point at the lower directory /c0-t0 as input? ie. Platynereis-H2B-TL.ome.zarr/c0-t0

@constantinpape
Copy link
Author

Thanks @will-moore . That did the trick! And I understand the issue now; there was still a conceptual misunderstanding from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants