Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immunize URLs against changes to label casing #216

Closed
osteele opened this issue May 8, 2018 · 0 comments
Closed

Immunize URLs against changes to label casing #216

osteele opened this issue May 8, 2018 · 0 comments
Assignees

Comments

@osteele
Copy link
Contributor

osteele commented May 8, 2018

It's likely (#211) that Final Events will change to final events or final-events.

(Even if we decide on capitalized feature names, we might apply the capitalization in the presentation layer.)

Insure that previously bookmarked URLs such as http://events.olin.build/calendar/academic,featured,Final%20Events,food,holidays,StAR (note the presence of Final%20Events) continue to work in this case.

This can be done by normalizing the elements of state.labels.visibleLabels in calendar-container.js against a map of normalized label names.

@osteele osteele self-assigned this May 8, 2018
osteele added a commit that referenced this issue May 8, 2018
Completes #216.

This also adds a `withServerData` HOC, that will be useful in #217.
osteele added a commit that referenced this issue May 8, 2018
Completes #216.

This also adds a `withServerData` HOC, that will be useful in #217.
osteele added a commit that referenced this issue May 8, 2018
Completes #216.

This also adds a `withServerData` HOC, that will be useful in #217.
@osteele osteele closed this as completed May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant