Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with start and end times for all-day events #213

Open
osteele opened this issue May 7, 2018 · 0 comments
Open

Issues with start and end times for all-day events #213

osteele opened this issue May 7, 2018 · 0 comments
Projects

Comments

@osteele
Copy link
Contributor

osteele commented May 7, 2018

In add-edit-page.js#132:

      if (eventData.allDay) {
        eventData.start.startOf('day');
        eventData.end.endOf('day');
      }
  1. eventData.start.startOf('day') should presumably be eventData.start = eventData.start.startOf('day'), ditto for eventData.end.
  2. eventData.end.endOf('day') sets the time to 23:59:59. Presumably what's wanted is actually startOf('day').
  3. These times are start of (and, given (2), end of) day in local time. Presumably this should be in UTC.
@osteele osteele added this to Product backlog in Roadmap May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Roadmap
  
Product backlog
Development

No branches or pull requests

1 participant