Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove “unlabeled” label from events.label #234

Open
osteele opened this issue May 7, 2018 · 0 comments
Open

Remove “unlabeled” label from events.label #234

osteele opened this issue May 7, 2018 · 0 comments
Labels
api Issues that affect the ABE API clients

Comments

@osteele
Copy link
Contributor

osteele commented May 7, 2018

There's lot of special-casing around the maintenance of “unlabeled” label for events that don't otherwise have a label.

Remove this.

It's not currently used in the UI. If it is restored, it should be handled differently, by special-casing just the GET /events search and response. The currently implementation probably does not handle the cases of editing event label lists correctly, and would need to be better tested if it were maintained. It would also need some design around whether it's okay to have an item in events.labels that isn't in the labels collection, and whether it's valid to explicitly add "unlabeled" to an item.

@osteele osteele added the api Issues that affect the ABE API clients label May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues that affect the ABE API clients
Projects
None yet
Development

No branches or pull requests

1 participant