Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GET requests with invalid rec_id returns an internal server error #203

Open
newsch opened this issue Apr 30, 2018 · 1 comment
Open

GET requests with invalid rec_id returns an internal server error #203

newsch opened this issue Apr 30, 2018 · 1 comment
Labels
api Issues that affect the ABE API clients bug good first issue Good issues for first-time contributors

Comments

@newsch
Copy link
Collaborator

newsch commented Apr 30, 2018

Steps to reproduce:

  1. Pick an event (recurring or not).
  2. Pick any string that will not be evaluated by rrule, e.g. 2018-03-34 or hello_there.
  3. GET abe.olin.build/events/ID/REC_ID.
@newsch newsch added bug api Issues that affect the ABE API clients labels Apr 30, 2018
@kylecombes
Copy link
Contributor

Probably should return a 404 (and not crash on the server side).

@kylecombes kylecombes added the good first issue Good issues for first-time contributors label Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Issues that affect the ABE API clients bug good first issue Good issues for first-time contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kylecombes @newsch